Re: Index AM API cleanup

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Kirill Reshke <reshkekirill(at)gmail(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Alex Wang <alex(dot)wang(at)enterprisedb(dot)com>, Paul A Jungwirth <pj(at)illuminatedcomputing(dot)com>
Subject: Re: Index AM API cleanup
Date: 2024-12-04 14:49:20
Message-ID: 5b2e1e60-5014-407b-9282-699e7d82853a@eisentraut.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 27.11.24 13:57, Peter Eisentraut wrote:
> I think, however, that we should rename RowCompareType.  Otherwise, it's
> just going to be confusing forevermore.  I suggest to rename it simply
> to CompareType.

> I'm going to try to code up the gist support on top of this patch set to
> make sure that it will fit well.  I'll report back.

Here is a patch set in that direction. It renames RowCompareType to
CompareType and updates the surrounding commentary a bit. And then I'm
changing the gist strategy mapping to use the CompareType values instead
of the RT* strategy numbers. Seeing this now, I like this a lot better
than what we have now, because it makes it clearer in the API and the
code what is a real strategy number and what's a different kind of
thing. (This isn't entirely the above-mentioned integration of the gist
support into your patch set yet, but it's a meaningful part of it.)

Attachment Content-Type Size
v19.1-0001-Rename-RowCompareType-to-CompareType.patch text/plain 12.5 KB
v19.1-0002-Change-gist-stratnum-function-to-use-CompareTy.patch text/plain 30.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Malladi, Rama 2024-12-04 14:51:39 Re: [PATCH] SVE popcount support
Previous Message Daniel Gustafsson 2024-12-04 14:48:00 Re: add support for the old naming libs convention on windows (ssleay32.lib and libeay32.lib)