Re: New "raw" COPY format

On Mon, Oct 28, 2024, at 08:56, jian he wrote:
> /* Check force_quote */
> - if (!opts_out->csv_mode && (opts_out->force_quote ||
> opts_out->force_quote_all))
> + if (opts_out->format != COPY_FORMAT_CSV && (opts_out->force_quote ||
> + opts_out->force_quote_all))
> ereport(ERROR,
> (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
> /*- translator: %s is the name of a COPY option, e.g. ON_ERROR */
>
> maybe this has a code indentation issue.
> since "if" and "opts_out" in the same column position.

Thanks for review.

I've fixed the indentation issues.

> It came to my mind,
> change errmsg occurrence of "BINARY mode", "CSV mode" to "binary
> format", "csv format" respectively.
> I think "format" would be more accurate.
> but the message seems invasive,
> so i guess we need to use "mode".

That would work, I'm fine with either.

> overall v13-0001-Introduce-CopyFormat-and-replace-csv_mode-and-binary.patch
> looks good to me.

Cool.

/Joel