| From: | Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Stephen Frost <sfrost(at)snowman(dot)net>, Maksim Milyutin <milyutinma(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] Add support for tuple routing to foreign partitions |
| Date: | 2018-04-04 10:31:09 |
| Message-ID: | 5AC4A96D.7000705@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
(2018/04/03 22:01), Etsuro Fujita wrote:
> Attached is an updated version of the patch. Patch
> foreign-routing-fdwapi-3.patch is created on top of patch
> postgres-fdw-refactoring-3.patch and the bug-fix patch [1].
One thing I noticed about patch foreign-routing-fdwapi-3.patch is this
bug: the server will crash when copying data into a foreign table that
doesn't support the proposed APIs (eg, file_fdw foreign tables). The
reason is that the patch doesn't perform CheckValidResultRel before that
operation in that case. So I modified the patch as such and added
regression tests for that.
Attached is an updated version of the patch set:
* As before, patch foreign-routing-fdwapi-4.patch is created on top of
patch postgres-fdw-refactoring-4.patch and the bug-fix patch [1].
* I revised comments, docs, and regression tests a bit further, but no
code changes other than the bug fix.
Best regards,
Etsuro Fujita
[1] https://www.postgresql.org/message-id/5ABA4074.1090500@lab.ntt.co.jp
| Attachment | Content-Type | Size |
|---|---|---|
| postgres-fdw-refactoring-4.patch | text/x-diff | 11.3 KB |
| foreign-routing-fdwapi-4.patch | text/x-diff | 54.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2018-04-04 11:13:42 | Re: Optimize Arm64 crc32c implementation in Postgresql |
| Previous Message | Nikhil Sontakke | 2018-04-04 09:53:37 | Re: [HACKERS] logical decoding of two-phase transactions |