Re: Replace current implementations in crypt() and gen_salt() to OpenSSL

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Joe Conway <mail(at)joeconway(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, "Koshi Shibagaki (Fujitsu)" <shibagaki(dot)koshi(at)fujitsu(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Replace current implementations in crypt() and gen_salt() to OpenSSL
Date: 2024-12-04 13:54:17
Message-ID: 58186585-5FC9-4507-B39B-65FECBCF5894@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 3 Dec 2024, at 22:56, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
>> On 3 Dec 2024, at 15:04, Joe Conway <mail(at)joeconway(dot)com> wrote:
>>
>> On 12/3/24 08:59, Daniel Gustafsson wrote:
>>>> On 24 Nov 2024, at 14:48, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>>> Any other opinions or should we proceed with the proposed GUC?
>>
>> I'm good with it. Did you want to commit or would you rather I do it?
>
> No worries, I can make it happen. ssnce there has been no objections since
> this patch was posted I'll get it commmitted shortly.

Looking over this again I realized it's a bit silly to fall back on FIPS_mode()
when EVP_default_properties_is_fips_enabled isn't available since that would
only be OpenSSL versions before 3.0 (and since we don't support 1.0.2 then no
such version can have FIPS). Sharing back a v3 which is what I think we should
go with.

--
Daniel Gustafsson

Attachment Content-Type Size
v3-0001-pgcrypto-Make-it-possible-to-disable-built-in-cry.patch application/octet-stream 8.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2024-12-04 14:08:53 Re: Guidance Needed for Testing PostgreSQL Patch (CF-5044)
Previous Message Daniel Gustafsson 2024-12-04 13:44:18 Re: Serverside SNI support in libpq