From: | "Bossart, Nathan" <bossartn(at)amazon(dot)com> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Magnus Hagander <magnus(at)hagander(dot)net>, Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, Don Seiler <don(at)seiler(dot)us>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Estimating HugePages Requirements? |
Date: | 2021-09-07 17:08:43 |
Message-ID: | 578A8F79-FD13-4408-865F-4D31EE5D8123@amazon.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-admin pgsql-hackers |
On 9/6/21, 9:00 PM, "Michael Paquier" <michael(at)paquier(dot)xyz> wrote:
> + sprintf(buf, "%lu MB", size_mb);
> + SetConfigOption("shared_memory_size", buf, PGC_INTERNAL, PGC_S_OVERRIDE);
> One small-ish comment about 0002: there is no need to add the unit
> into the buffer set as GUC_UNIT_MB would take care of that. The patch
> looks fine.
I fixed this in v7.
> +#ifndef WIN32
> +#include <sys/mman.h>
> +#endif
> So, this is needed in ipci.c to check for MAP_HUGETLB. I am not much
> a fan of moving around platform-specific checks when these have
> remained local to each shmem implementation. Could it be cleaner to
> add GetHugePageSize() to win32_shmem.c and make it always declared in
> the SysV implementation?
I don't know if it's really all that much cleaner, but I did it this
way in v7. IMO it's a little weird that GetHugePageSize() doesn't
return the value from GetLargePageMinimum(), but that's what we'd need
to do to avoid setting huge_pages_required for Windows without any
platform-specific checks.
Nathan
Attachment | Content-Type | Size |
---|---|---|
v7-0003-Provide-useful-values-for-postgres-C-with-runtime.patch | application/octet-stream | 10.3 KB |
v7-0002-Introduce-huge_pages_required-GUC.patch | application/octet-stream | 6.3 KB |
v7-0001-Introduce-shared_memory_size-GUC.patch | application/octet-stream | 4.5 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Bossart, Nathan | 2021-09-07 17:09:08 | Re: Estimating HugePages Requirements? |
Previous Message | Swati Patil | 2021-09-07 16:39:51 | Re: Standby.signal file is not getting deleted after failover in all scanarios |
From | Date | Subject | |
---|---|---|---|
Next Message | Bossart, Nathan | 2021-09-07 17:09:08 | Re: Estimating HugePages Requirements? |
Previous Message | Tom Lane | 2021-09-07 16:58:44 | Re: [PATCH] Add `verify-system` sslmode to use system CA pool for server cert |