From: | Petr Jelinek <petr(at)2ndquadrant(dot)com> |
---|---|
To: | Artur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru>, Andres Freund <andres(at)anarazel(dot)de> |
Cc: | Simon Riggs <simon(at)2ndQuadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Craig Ringer <craig(at)2ndquadrant(dot)com> |
Subject: | Re: Proposal: Generic WAL logical messages |
Date: | 2016-03-09 23:58:14 |
Message-ID: | 56E0B896.3050007@2ndquadrant.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 08/03/16 21:21, Artur Zakirov wrote:
> I think here
>
>> +const char *
>> +logicalmsg_identify(uint8 info)
>> +{
>> + if (info & ~XLR_INFO_MASK == XLOG_LOGICAL_MESSAGE)
>> + return "MESSAGE";
>> +
>> + return NULL;
>> +}
>
> we should use brackets
>
> const char *
> logicalmsg_identify(uint8 info)
> {
> if ((info & ~XLR_INFO_MASK) == XLOG_LOGICAL_MESSAGE)
> return "MESSAGE";
>
> return NULL;
> }
>
Correct, fixed, thanks.
I also rebased this as there was conflict after the fixes to logical
decoding by Andres.
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
Attachment | Content-Type | Size |
---|---|---|
logical-messages-2016-03-10.patch | text/x-patch | 39.7 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Petr Jelinek | 2016-03-10 00:26:23 | Re: Reworks of CustomScan serialization/deserialization |
Previous Message | Haribabu Kommi | 2016-03-09 23:49:09 | Re: [HACKERS] Re: [HACKERS] Re: [HACKERS] Windows service is not starting so there’s message in log: FATAL: "could not create shared memory segment “Global/PostgreSQL.851401618”: Permission denied” |