On 07.11.24 10:35, Dean Rasheed wrote:
> On Tue, 5 Nov 2024 at 16:17, Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
>>
>> New patch version.
>
> What happened with the RLS support? It looks like you moved the code
> to expand virtual generated columns back to the first loop in
> fireRIRrules(), which doesn't work because RLS policies might contain
> references to virtual generated columns.
>
> In the v7 patch, it was done in a separate loop, after the RLS policy
> loop, which I thought was fine, except that I didn't like having a
> whole new loop, opening and closing all the relations in the query.
> Was there some other problem with that approach?
I have no idea what happened there. I must have used the wrong patch
version at some point. I have applied your patch to fix that back up.
Also thanks for the RLS test cases.