| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
| Cc: | PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: libpq connection timeout mismanagement |
| Date: | 2018-08-14 17:17:12 |
| Message-ID: | 5106.1534267032@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> writes:
>> Right. As before, I'm not excited about rejecting trailing junk,
>> considering we never did before.
> My 0.02¤: accepting trailing junk is just a recipee for hiding bugs:
> sh> psql "connect_timeout=2,port=5433"
> psql> \conninfo
> ... port=5432 # port directive was silently ignored
> So erroring out would be a good thing, and it could be done on a new
> release.
Perhaps. That should certainly be a separate patch, though, and
it should cover everything not just connection_timeout (I see at
least five parameters that are parsed with atoi() and nothing else).
I'm still not excited, but feel free to send a patch.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-08-14 17:18:45 | Re: Pre-v11 appearances of the word "procedure" in v11 docs |
| Previous Message | Tels | 2018-08-14 17:01:48 | Re: Undocumented(?) limits on regexp functions |