From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
---|---|
To: | Melih Mutlu <m(dot)melihmutlu(at)gmail(dot)com> |
Cc: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Refactor ssl tests to avoid using internal PostgreSQL::Test::Cluster methods |
Date: | 2023-05-31 14:12:42 |
Message-ID: | 4947AE27-A754-43B6-BC2E-8504AB2A8BD3@yesql.se |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> On 31 May 2023, at 15:46, Melih Mutlu <m(dot)melihmutlu(at)gmail(dot)com> wrote:
> I was comparing this new restart function to start and stop functions.
> I see that restart() does not return a value if it's successful while
> others return 1.
> Its return value is not checked anywhere, so it may not be useful at
> the moment. But I feel like it would be nice to make it look like
> start()/stop(). What do you think?
It should absolutely return 1, that was an oversight. Fixed as well as
documentation updated.
>> command_fails(
>> [ 'pg_ctl', '-D', $node->data_dir, '-l', $node->logfile, 'restart' ],
>> 'restart fails with incorrect SSL protocol bounds');
>
> There are two other places where ssl tests restart the node like
> above. We can call $node->restart in those lines too.
Fixed in the attached v2.
--
Daniel Gustafsson
Attachment | Content-Type | Size |
---|---|---|
v2-0001-Avoid-using-internal-test-methods-in-SSL-tests.patch | application/octet-stream | 4.2 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Tomas Vondra | 2023-05-31 14:53:23 | Re: Do we want a hashset type? |
Previous Message | Joel Jacobson | 2023-05-31 14:09:55 | Do we want a hashset type? |