| From: | Nikolay Shaplov <dhyan(at)nataraj(dot)su> |
|---|---|
| To: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, Jeremy Schneider <schnjere(at)amazon(dot)com>, Joe Conway <mail(at)joeconway(dot)com>, Peter Geoghegan <pg(at)bowt(dot)ie> |
| Subject: | [PATCH][HOTFIX] vacuum_cost_delay type change from int to real have not been done everywhere |
| Date: | 2019-03-26 16:19:50 |
| Message-ID: | 4861742.12LTaSB3sv@x200m |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi!
In caf626b2 type of vacuum_cost_delay have been switched from int to real,
everywhere, but not in *RelOpts[] arrays.
For some reason it continued to build and work. But I think it is better to
move vacuum_cost_delay from int to real there too...
Patch attached.
PS. As you can see current reloption code is error-prone. To properly change
reloptions you should simultaneously change code in several different places,
and as you can see, it may not report if you missed something.
I am working on reloptions code refactoring now, please join reviewing my
patches. This work is important as you can see from this example...
| Attachment | Content-Type | Size |
|---|---|---|
| vacuum_cost_delay_hotfix_1.diff | text/x-patch | 1.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2019-03-26 16:35:33 | Re: Tid scan improvements |
| Previous Message | Tom Lane | 2019-03-26 16:06:15 | Re: speeding up planning with partitions |