From: | "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Andres Freund <andres(at)anarazel(dot)de>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>, Amit Khandekar <amitdkhan(dot)pg(at)gmail(dot)com>, fabriziomello(at)gmail(dot)com, tushar <tushar(dot)ahuja(at)enterprisedb(dot)com>, Rahila Syed <rahila(dot)syed(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Minimal logical decoding on standbys |
Date: | 2022-12-14 13:05:15 |
Message-ID: | 47f5faf0-6a6d-602a-5d5b-9449ca74c6ad@gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
On 12/13/22 5:37 PM, Drouvot, Bertrand wrote:
> Hi,
>
> On 12/13/22 2:50 PM, Robert Haas wrote:
>> On Tue, Dec 13, 2022 at 5:49 AM Drouvot, Bertrand
>
>> It seems kind of unfortunate to have to add payload to a whole bevy of
>> record types for this feature. I think it's worth it, both because the
>> feature is extremely important,
>
> Agree and I don't think that there is other option than adding some payload in some WAL records (at the very beginning the proposal was to periodically log a new record
> that announces the current catalog xmin horizon).
>
>> and also because there aren't any
>> record types that fall into this category that are going to be emitted
>> so frequently as to make it a performance problem.
>
> +1
>
> If no objections from your side, I'll submit a patch proposal by tomorrow, which:
>
> - get rid of IndexIsAccessibleInLogicalDecoding
> - let RelationIsAccessibleInLogicalDecoding deals with the index case
> - takes care of the padding where the new bool is added
> - convert this new bool to a flag for the xl_heap_visible case (adding a new bit to the already existing flag)
> - Add my proposed wording above to the commit message
> - Add your proposed wording above in a README
Please find attached v31 with the changes mentioned above (except that I put your wording into the commit message instead of a README: I think it helps to make
clear what the "design" for the patch series is).
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
Attachment | Content-Type | Size |
---|---|---|
v31-0006-Fixing-Walsender-corner-case-with-logical-decodi.patch | text/plain | 7.5 KB |
v31-0005-Doc-changes-describing-details-about-logical-dec.patch | text/plain | 2.1 KB |
v31-0004-New-TAP-test-for-logical-decoding-on-standby.patch | text/plain | 20.4 KB |
v31-0003-Allow-logical-decoding-on-standby.patch | text/plain | 11.5 KB |
v31-0002-Handle-logical-slot-conflicts-on-standby.patch | text/plain | 28.0 KB |
v31-0001-Add-info-in-WAL-records-in-preparation-for-logic.patch | text/plain | 28.8 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Langote | 2022-12-14 13:28:46 | Re: Allow batched insert during cross-partition updates |
Previous Message | Amul Sul | 2022-12-14 12:35:02 | Re: Error-safe user functions |