From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
---|---|
To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
Cc: | Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [HACKERS] Optional message to user when terminating/cancelling backend |
Date: | 2018-01-25 23:05:39 |
Message-ID: | 4614BA96-0085-4139-8C18-0552FFF66AF8@yesql.se |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> On 24 Jan 2018, at 16:45, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
>
> A quick suggestion from a passer-by -- would you put the new code in
> src/backend/storage/ipc/backend_signal.c instead? Sounds like a better
> place than utils/misc/; and "signal" is more general in nature than just
> "cancel". A bunch of stuff from utils/adt/misc.c (???) can migrate to
> the new file -- everything from line 201 to 362 at least, that is:
>
> pg_signal_backend
> pg_cancel_backend
> pg_terminate_backend
> pg_reload_conf
> pg_rotate_logfile
+1, this makes a lot of sense. When writing this I didn’t find a good fit
anywhere so I modelled it after utils/misc/backend_random.c, not because it was
a good fit but it was the least bad one I could come up with. This seems a lot
cleaner.
> Maybe have two patches, 0001 creates the files moving the contents over,
> then 0002 adds your new stuff on top.
The two attached patches implements this.
> /me wonders if there's anything that would suggest to make this
> extensive to processes other than backends ...
Perhaps, do you have an API in mind?
cheers ./daniel
Attachment | Content-Type | Size |
---|---|---|
0001-Refactor-backend-signalling-code-v6.patch | application/octet-stream | 13.1 KB |
0002-Support-optional-message-in-backend-cancel-terminate-v6.patch | application/octet-stream | 16.3 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Daniel Gustafsson | 2018-01-25 23:27:16 | Re: [HACKERS] GnuTLS support |
Previous Message | Fabien COELHO | 2018-01-25 22:46:24 | Re: PATCH: pgbench - option to build using ppoll() for larger connection counts |