Re: Provide a pg_truncate_freespacemap function

From: Ronan Dunklau <ronan(dot)dunklau(at)aiven(dot)io>
To: Stephen Frost <sfrost(at)snowman(dot)net>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Provide a pg_truncate_freespacemap function
Date: 2024-03-07 07:59:02
Message-ID: 4331161.ejJDZkT8p0@aivenlaptop
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Le mercredi 6 mars 2024, 20:28:44 CET Stephen Frost a écrit :
> I agree that this would generally be a useful thing to have.

Thanks !

>
> > Does that seem correct ?
>
> Definitely needs to have a 'REVOKE ALL ON FUNCTION' at the end of the
> upgrade script, similar to what you'll find at the bottom of
> pg_visibility--1.1.sql in the tree today, otherwise anyone could run it.
>
> Beyond that, I'd suggest a function-level comment above the definition
> of the function itself (which is where we tend to put those- not at the
> point where we declare the function).

Thank you for the review. Here is an updated patch for both of those.

Best regards,

--
Ronan

Attachment Content-Type Size
0002-Provide-a-pg_truncate_freespacemap-function.patch text/x-patch 4.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrei Lepikhov 2024-03-07 08:17:10 Re: a wrong index choose when statistics is out of date
Previous Message Nikita Malakhov 2024-03-07 07:33:18 Re: Shared detoast Datum proposal