From: | Dilip kumar <dilip(dot)kumar(at)huawei(dot)com> |
---|---|
To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com> |
Cc: | Sawada Masahiko <sawada(dot)mshk(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Jan Lentfer <Jan(dot)Lentfer(at)web(dot)de>, "Euler Taveira" <euler(at)timbira(dot)com(dot)br> |
Subject: | Re: TODO : Allow parallel cores to be used by vacuumdb [ WIP ] |
Date: | 2014-07-04 05:15:06 |
Message-ID: | 4205E661176A124FAF891E0A6BA9135266340046@szxeml509-mbs.china.huawei.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 02 July 2014 23:45, Alvaro Herrera Wrote,
>
> Well, there are (at least) two types of duplicate code: first you have
> these common routines such as pgpipe that are duplicates for no good
> reason. Just move them to src/port or something and it's all good.
> But the OP said there is code that cannot be shared even though it's
> very similar in both incarnations. That means we cannot (or it's
> difficult
> to) just have one copy, which means as they fix bugs in one copy we
> need to update the other. This is bad -- witness the situation with
> ecpg's copy of date/time code, where there are bugs fixed in the
> backend version but the ecpg version does not have the fix. It's
> difficult to keep track of these things.
In attached patch, I have moved pgpipe, piperead functions to src/port/pipe.c
There are some more common function what Jeff and Amit also mentioned to move to common place,
Currently I am not sure where we can move other functions to.
Can we move other parallel functions to src/port, may be one new file parallel.c under src/port ?
Thanks & Regards,
Dilip Kumar
Attachment | Content-Type | Size |
---|---|---|
vacuumdb_parallel_v8.patch | application/octet-stream | 56.4 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Fujii Masao | 2014-07-04 05:38:27 | Re: [REVIEW] Re: Compression of full-page-writes |
Previous Message | Ashoke | 2014-07-04 05:13:12 | Issue while calling new PostgreSQL command from a Java Application |