From: | bt23nguyent <bt23nguyent(at)oss(dot)nttdata(dot)com> |
---|---|
To: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Improve the log message output of basic_archive when basic_archive.archive_directory parameter is not set |
Date: | 2023-09-15 09:38:37 |
Message-ID: | 4109578306242a7cd5661171647e11b2@oss.nttdata.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
When archive_library is set to 'basic_archive' but
basic_archive.archive_directory is not set, WAL archiving doesn't work
and only the following warning message is logged.
$ emacs $PGDATA/postgresql.conf
archive_mode = on
archive_library = 'basic_archive'
$ bin/pg_ctl -D $PGDATA restart
....
WARNING: archive_mode enabled, yet archiving is not configured
The issue here is that this warning message doesn't suggest any hint
regarding the cause of WAL archiving failure. In other words, I think
that the log message in this case should report that WAL archiving
failed because basic_archive.archive_directory is not set. Thus, I think
it's worth implementing new patch that improves that warning message,
and here is the patch for that.
Best regards,
Tung Nguyen
Attachment | Content-Type | Size |
---|---|---|
v1-0001-Improve-log-message-output-of-basic-archive.patch | text/x-diff | 2.9 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | vignesh C | 2023-09-15 09:42:16 | Re: pg_upgrade and logical replication |
Previous Message | vignesh C | 2023-09-15 09:38:21 | Re: pg_upgrade and logical replication |