| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Remove last traces of SCM credential auth from libpq? |
| Date: | 2023-03-17 00:10:12 |
| Message-ID: | 4037249.1679011812@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Michael Paquier <michael(at)paquier(dot)xyz> writes:
> On Thu, Mar 16, 2023 at 10:49:45AM -0400, Tom Lane wrote:
>> Also, in pg_fe_sendauth, couldn't you just let the default: case
>> handle it instead of adding a bespoke error message? We're not
>> really expecting that anyone is ever going to hit this, so I'm
>> not convinced it's worth the translation burden.
> Yes, I was wondering if that's worth keeping or not, so I chose
> consistency with AUTH_REQ_KRB4 and AUTH_REQ_KRB5.
Maybe flush those special messages too? I'm not sure how long
they've been obsolete, though.
> Would it be better to hold on this patch for 17~?
Nah, I see no reason to wait. We already dropped the higher-level
client support (psql/pg_dump) for these server versions in v15.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2023-03-17 00:11:37 | Re: Dropped and generated columns might cause wrong data on subs when REPLICA IDENTITY FULL |
| Previous Message | Amit Kapila | 2023-03-17 00:08:50 | Re: Dropped and generated columns might cause wrong data on subs when REPLICA IDENTITY FULL |