From: | "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com> |
---|---|
To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Jeff Davis <pgsql(at)j-davis(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>, Amit Khandekar <amitdkhan(dot)pg(at)gmail(dot)com>, fabriziomello(at)gmail(dot)com, tushar <tushar(dot)ahuja(at)enterprisedb(dot)com>, Rahila Syed <rahila(dot)syed(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Minimal logical decoding on standbys |
Date: | 2023-04-07 05:02:04 |
Message-ID: | 3c9d4998-a338-081f-a5f6-d038ead75384@gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
On 4/6/23 4:20 PM, Drouvot, Bertrand wrote:
> Hi,
>
> On 4/6/23 3:39 PM, Amit Kapila wrote:
>> On Thu, Apr 6, 2023 at 6:32 PM Drouvot, Bertrand
>> <bertranddrouvot(dot)pg(at)gmail(dot)com> wrote:
>>>
>>>
>>> I don't think it could be possible to create logical walsenders on a standby if
>>> AllowCascadeReplication() is not true, or am I missing something?
>>>
>>
>> Right, so why to even traverse walsenders for that case? What I was
>> imagining a code is like:
>> if (AllowCascadeReplication())
>> WalSndWakeup(switchedTLI, true);
>>
>> Do you see any problem with this change?
>
> Not at all, it looks good to me.
>
>>
Done in V63 attached and did change the associated comment a bit.
>> Few more minor comments on 0005
>> =============================
>> 0005
>> 1.
>> + <para>
>> + Take a snapshot of running transactions and write this to WAL without
>> + having to wait bgwriter or checkpointer to log one.
>>
>> /wait bgwriter/wait for bgwriter
>>
>> 2.
>> +use Test::More tests => 67;
>>
>> We no more use the number of tests. Please refer to other similar tests.
>>
>
> Thanks! Will update 0005.
>
Done in V63.
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
Attachment | Content-Type | Size |
---|---|---|
v63-0006-Doc-changes-describing-details-about-logical-dec.patch | text/plain | 2.7 KB |
v63-0005-New-TAP-test-for-logical-decoding-on-standby.patch | text/plain | 32.6 KB |
v63-0004-For-cascading-replication-wake-up-physical-walse.patch | text/plain | 9.6 KB |
v63-0003-Allow-logical-decoding-on-standby.patch | text/plain | 12.3 KB |
v63-0002-Arrange-for-a-new-pg_stat_database_conflicts-and.patch | text/plain | 10.4 KB |
v63-0001-Handle-logical-slot-conflicts-on-standby.patch | text/plain | 27.5 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Drouvot, Bertrand | 2023-04-07 05:02:45 | Re: Minimal logical decoding on standbys |
Previous Message | Drouvot, Bertrand | 2023-04-07 05:00:27 | Re: Minimal logical decoding on standbys |