From: | "Imseih (AWS), Sami" <simseih(at)amazon(dot)com> |
---|---|
To: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
Cc: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Peter Geoghegan <pg(at)bowt(dot)ie>, "Bossart, Nathan" <bossartn(at)amazon(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Add index scan progress to pg_stat_progress_vacuum |
Date: | 2021-12-31 05:59:15 |
Message-ID: | 39E8ED08-56E6-4466-93BF-3FD3D51EE52C@amazon.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Attaching the latest revision of the patch with the fixes suggested. Also ran make check and make check-world successfully.
On 12/29/21, 11:51 AM, "Justin Pryzby" <pryzby(at)telsasoft(dot)com> wrote:
CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.
http://cfbot.cputube.org/sami-imseih.html
You should run "make check" and update rules.out.
You should also use make check-world - usually something like:
make check-world -j4 >check-world.out 2>&1 ; echo ret $?
> indrelid: The relid of the index currently being vacuumed
I think it should be called indexrelid not indrelid, for consistency with
pg_index.
> S.param10 vacuum_cycle_ordinal_position,
> S.param13 index_rows_vacuumed
These should both say "AS" for consistency.
system_views.sql is using tabs, but should use spaces for consistency.
> #include "commands/progress.h"
The postgres convention is to alphabetize the includes.
> /* VACCUM operation's longest index scan cycle */
VACCUM => VACUUM
Ultimately you'll also need to update the docs.
Attachment | Content-Type | Size |
---|---|---|
0001-Add-index-scan-progress-to-pg_stat_progress_vacuum.patch | application/octet-stream | 18.1 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2021-12-31 06:03:01 | Re: Patch to avoid orphaned dependencies |
Previous Message | Andres Freund | 2021-12-31 03:17:33 | Re: Adding CI to our tree |