From: | Masahiro Ikeda <ikedamsh(at)oss(dot)nttdata(dot)com> |
---|---|
To: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Cc: | tsunakawa(dot)takay(at)fujitsu(dot)com, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
Subject: | Re: New statistics for tuning WAL buffer size |
Date: | 2020-08-24 11:45:36 |
Message-ID: | 399134b25c8f5d6565aba59d2ee9254b@oss.nttdata.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi, thanks for useful comments.
>> I agree to expose the number of WAL write caused by full of WAL
>> buffers.
>> It's helpful when tuning wal_buffers size. Haribabu separated that
>> number
>> into two fields in his patch; one is the number of WAL write by
>> backend,
>> and another is by background processes and workers. But I'm not sure
>> how useful such separation is. I'm ok with just one field for that
>> number.
> I agree with you. I don't think we need to separate the numbers for
> foreground processes and background ones. WAL buffer is a single
> resource. So "Writes due to full WAL buffer are happening. We may be
> able to boost performance by increasing wal_buffers" would be enough.
I made a patch to expose the number of WAL write caused by full of WAL
buffers.
I'm going to submit this patch to commitfests.
As Fujii-san and Tsunakawa-san said, it expose the total number
since I agreed that we don't need to separate the numbers for
foreground processes and background ones.
By the way, do we need to add another metrics related to WAL?
For example, is the total number of WAL writes to the buffers useful to
calculate the dirty WAL write ratio?
Is it enough as a first step?
Regards,
--
Masahiro Ikeda
NTT DATA CORPORATION
Attachment | Content-Type | Size |
---|---|---|
0001_pg_stat_walwrites_view.patch | text/x-diff | 12.6 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Masahiro Ikeda | 2020-08-24 12:00:56 | Re: New statistics for tuning WAL buffer size |
Previous Message | Christoph Berg | 2020-08-24 11:34:45 | Re: deb repo doesn't have latest. or possible to update web page? |