| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Matheus Alcantara <matheusssilv97(at)gmail(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Gabriele Bartolini <gabriele(dot)bartolini(at)enterprisedb(dot)com>, Craig Ringer <craig(dot)ringer(at)enterprisedb(dot)com>, "David E(dot) Wheeler" <david(at)justatheory(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: RFC: Additional Directory for Extensions |
| Date: | 2025-03-06 13:46:08 |
| Message-ID: | 38c53446-6b65-4222-b76b-351e56f4841c@eisentraut.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 03.03.25 19:45, Matheus Alcantara wrote:
> Hi, attached a new v5 with some minor improvements on TAP tests:
>
> - Add a proper test name for all test cases
> - Add CREATE EXTENSION command execution
> - Change the assert on pg_available_extensions and
> pg_available_extension_versions to validate the row content
>
> Also rebased with master
This looks very good to me. I have one issue to point out: The logic
in get_extension_control_directories() needs to be a little bit more
careful to align with the rules in find_in_path(). For example, it
should use first_path_var_separator() to get the platform-specific path
separator, and probably also substitute_path_macro() and
canonicalize_path() etc., to keep everything consistent. (Maybe it
would be ok to move the function to dfmgr.c to avoid having to export
too many things from there.)
Independent of that, attached is a small patch that suggests to use the
newer foreach_ptr() macro in some places.
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Use-foreach_ptr.patch.nocfbot | text/plain | 2.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Corey Huinker | 2025-03-06 13:49:33 | Re: Statistics Import and Export |
| Previous Message | jian he | 2025-03-06 13:44:11 | Re: support virtual generated column not null constraint |