| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at> |
| Cc: | Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Virender Singla <virender(dot)cse(at)gmail(dot)com>, pgsql-bugs(at)lists(dot)postgresql(dot)org, Aniket Jha <aniketkumarj(at)gmail(dot)com> |
| Subject: | Re: Major Version Upgrade failure due to orphan roles entries in catalog |
| Date: | 2025-02-21 21:45:18 |
| Message-ID: | 3672962.1740174318@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at> writes:
> On Fri, 2025-02-21 at 11:31 -0500, Tom Lane wrote:
>> ... Or maybe the better answer
>> is to conclude that the whole idea of not calling
>> CommandCounterIncrement unconditionally is too fragile and not worth
>> expending brain cells on, and just rip out the if-test.
> Both the extra sentence and the simplification feel like an improvement.
> I am fine with either.
The more I think about it the more I like just getting rid of the
test. It'll likely break with every future change to this logic,
until somebody finally gives up on it; so why not now?
I'll make it so. Thanks for reviewing!
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2025-02-21 23:05:10 | Re: Query result differences between PostgreSQL 17 vs 16 |
| Previous Message | Laurenz Albe | 2025-02-21 21:39:40 | Re: Major Version Upgrade failure due to orphan roles entries in catalog |