Missing free_var() at end of accum_sum_final()?

From: "Joel Jacobson" <joel(at)compiler(dot)org>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Missing free_var() at end of accum_sum_final()?
Date: 2023-02-16 05:59:13
Message-ID: 35fb0533-1e3e-42f6-b989-ce1f9b5f3ebe@app.fastmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

I noticed the NumericVar's pos_var and neg_var are not free_var()'d at the end of accum_sum_final().

The potential memory leak seems small, since the function is called only once per sum() per worker (and from a few more places), but maybe they should be free'd anyways for correctness?

/Joel

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2023-02-16 06:16:14 Re: Dead code in ps_status.c
Previous Message Amul Sul 2023-02-16 05:35:13 remove duplicate comment.