From: | Sergei Kornilov <sk(at)zsrv(dot)org> |
---|---|
To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, "andres(at)anarazel(dot)de" <andres(at)anarazel(dot)de>, "david(at)pgmasters(dot)net" <david(at)pgmasters(dot)net>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
Subject: | Re: allow online change primary_conninfo |
Date: | 2020-03-17 20:18:46 |
Message-ID: | 3315711584471826@sas1-d3a1bf2bd2e7.qloud-c.yandex.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hello
>> Well, it seems better to move this patch to next commitfest?
>
> What? You want to make wal_receiver_create_temp_slot unchangeable and
> default to off in pg13, and delay the patch that fixes those things to
> pg14? That makes no sense to me.
I want to handle similar things in a similar way.
wal_receiver_create_temp_slot has good design? I will change my patch in same way in this case. But something like that was strongly rejected a year ago.
> Please keep them both here so that we can get things to a usable state.
Yes, of course.
Here I attached 3 patches:
0001 is copy from https://commitfest.postgresql.org/27/2456/ It changes wal_receiver_create_temp_slot to PGC_POSTMASTER, changes the default value to off, and moves the logic to the startup process.
0002 changes primary_conninfo and primary_slot_name to be PGC_SIGHUP
0003 changes wal_receiver_create_temp_slot back to be PGC_SIGHUP. Michael Paquier asks to remove this from 0002, you ask to leave it in this thread. So, I made separate patch on top of 0002.
Thank you
regards, Sergei
Attachment | Content-Type | Size |
---|---|---|
0003_v9_reload_wal_receiver_create_temp_slot.patch | text/x-diff | 4.1 KB |
0002_v9_allow_reload_walreceiver_conninfo.patch | text/x-diff | 13.2 KB |
0001-v3-change-wal_receiver_create_temp_slot.patch | text/x-diff | 9.4 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Julien Rouhaud | 2020-03-17 20:32:22 | Re: WAL usage calculation patch |
Previous Message | Justin Pryzby | 2020-03-17 19:56:16 | Re: Berserk Autovacuum (let's save next Mandrill) |