From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
---|---|
To: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> |
Cc: | Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: meson: Optionally disable installation of test modules |
Date: | 2023-03-01 19:20:58 |
Message-ID: | 30b34214-67db-fcc5-7694-a6b028212da8@enterprisedb.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 23.02.23 19:06, Nazir Bilal Yavuz wrote:
> Hi,
>
> Thanks for the review.
>
> On Mon, 20 Feb 2023 at 21:44, Peter Eisentraut
> <peter(dot)eisentraut(at)enterprisedb(dot)com> wrote:
>>
>> I tested this a bit. It works fine. The approach makes sense to me.
>>
>> The install_additional_files script could be simplified a bit. You
>> could use os.makedirs(dest, exist_ok=True) and avoid the error checking.
>> I don't think any callers try to copy a directory source, so the
>> shutil.copytree() stuff isn't necessary. Run pycodestyle over the
>> script. And let's put the script into src/tools/ like the other support
>> scripts.
>>
>
> I updated the patch in line with your comments.
Looks good to me. I did a small pass over it to adjust some namings.
For example, I renamed test_install_files to test_install_data, so it's
consistent with the overall meson naming:
-install_data(
+test_install_data += files(
Let me know if you have any concerns about this version. Otherwise, I'm
happy to commit it.
Attachment | Content-Type | Size |
---|---|---|
v4-0001-meson-prevent-installation-of-test-files-during-m.patch | text/plain | 26.5 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Gregory Stark (as CFM) | 2023-03-01 19:24:41 | Re: [PATCH] Tracking statements entry timestamp in pg_stat_statements |
Previous Message | Nathan Bossart | 2023-03-01 19:13:44 | Re: add PROCESS_MAIN to VACUUM |