From: | Jim Jones <jim(dot)jones(at)uni-muenster(dot)de> |
---|---|
To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
Subject: | Re: [PATCH] Add pretty-printed XML output option |
Date: | 2023-02-14 21:55:20 |
Message-ID: | 2962ca3c-abf6-751a-85dc-a9356a384d82@uni-muenster.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 13.02.23 13:15, Jim Jones wrote:
> diff -U3 /tmp/cirrus-ci-build/src/test/regress/expected/xml.out /tmp/cirrus-ci-build/build/testrun/regress/regress/results/xml.out
> --- /tmp/cirrus-ci-build/src/test/regress/expected/xml.out 2023-02-12 09:02:57.077569000 +0000
> +++ /tmp/cirrus-ci-build/build/testrun/regress/regress/results/xml.out 2023-02-12 09:05:45.148100000 +0000
> @@ -1695,10 +1695,7 @@
> -- XML format: empty string
> SELECT xmlformat('');
> ERROR: invalid XML document
> -DETAIL: line 1: switching encoding : no input
> -
> -^
> -line 1: Document is empty
> +DETAIL: line 1: Document is empty
>
> ^
> -- XML format: invalid string (whitespaces)
I couldn't figure out why the error messages are different -- I'm
wondering if the issue is the test environment itself. I just removed
the troubling test case for now
SELECT xmlformat('');
v7 attached.
Thanks for reviewing this patch!
Best, Jim
Attachment | Content-Type | Size |
---|---|---|
v7-0001-Add-pretty-printed-XML-output-option.patch | text/x-patch | 19.2 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Nathan Bossart | 2023-02-14 22:05:18 | Re: Change xl_hash_vacuum_one_page.ntuples from int to uint16 |
Previous Message | Jonathan S. Katz | 2023-02-14 21:27:50 | Re: Move defaults toward ICU in 16? |