Re: [PATCH] Accept IP addresses in server certificate SANs

From: Jacob Champion <pchampion(at)vmware(dot)com>
To: "daniel(at)yesql(dot)se" <daniel(at)yesql(dot)se>, "tgl(at)sss(dot)pgh(dot)pa(dot)us" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "stark(at)mit(dot)edu" <stark(at)mit(dot)edu>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, "horikyota(dot)ntt(at)gmail(dot)com" <horikyota(dot)ntt(at)gmail(dot)com>
Subject: Re: [PATCH] Accept IP addresses in server certificate SANs
Date: 2022-03-28 20:21:17
Message-ID: 27dd89aa5bd8fac8fdfdbd33dd460422bcb77d6b.camel@vmware.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, 2022-03-28 at 11:17 +0200, Daniel Gustafsson wrote:
> Fixing up the switch_server_cert() calls and using default_ssl_connstr makes
> the test pass for me. The required fixes are in the supplied 0004 diff, I kept
> them separate to allow the original author to incorporate them without having
> to dig them out to see what changed (named to match the git format-patch output
> since I think the CFBot just applies the patches in alphabetical order).

Thanks! Those changes look good to me; I've folded them into v11. This
is rebased on a newer HEAD so it should fix the apply failures that
Greg pointed out.

--Jacob

Attachment Content-Type Size
v11-0001-Move-inet_net_pton-to-src-port.patch text/x-patch 4.5 KB
v11-0002-libpq-allow-IP-address-SANs-in-server-certs.patch text/x-patch 49.9 KB
v11-0003-squash-libpq-allow-IP-address-SANs-in-server-cer.patch text/x-patch 6.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2022-03-28 20:23:11 Re: [PATCH] Full support for index LP_DEAD hint bits on standby
Previous Message Greg Stark 2022-03-28 20:17:34 Re: range_agg with multirange inputs