Re: new heapcheck contrib module

From: Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Peter Geoghegan <pg(at)bowt(dot)ie>, Robert Haas <robertmhaas(at)gmail(dot)com>
Subject: Re: new heapcheck contrib module
Date: 2020-04-29 16:30:28
Message-ID: 2515838E-C202-406E-8E03-C146AE104E33@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


>> I wonder if a mode where heapcheck optionally would only checks
>> non-frozen (perhaps also non-all-visible) regions of a table would be a
>> good idea?

Version 4 of this patch now includes boolean options skip_all_frozen and skip_all_visible.

>> Would make it a lot more viable to run this regularly on
>> bigger databases. Even if there's a window to not check some data
>> (because it's frozen before the next heapcheck run).

Do you think it would make sense to have the amcheck contrib module have, in addition to the SQL queriable functions, a bgworker based mode that periodically checks your database? The work along those lines is not included in v4, but if it were part of v5, would you have specific design preferences?

Attachment Content-Type Size
v4-0001-Adding-verify_heapam-to-amcheck-contrib-module.patch application/octet-stream 58.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2020-04-29 17:28:53 Re: new heapcheck contrib module
Previous Message Alvaro Herrera 2020-04-29 16:29:07 Re: SEQUENCE values (duplicated) in some corner cases when crash happens