| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Erik Wienhold <ewie(at)ewie(dot)name>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Underscore in positional parameters? |
| Date: | 2024-05-16 06:41:11 |
| Message-ID: | 22b3febb-53b4-45af-b6ee-bbd16e39f61b@eisentraut.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 16.05.24 01:11, Michael Paquier wrote:
> On Wed, May 15, 2024 at 01:59:36PM +0200, Peter Eisentraut wrote:
>> On 14.05.24 18:07, Erik Wienhold wrote:
>>> Patch 0002 replaces atol with pg_strtoint32_safe in the backend parser
>>> and strtoint in ECPG. This fixes overflows like:
>>
>> Seems like a good idea, but as was said, this is an older issue, so let's
>> look at that separately.
>
> Hmm, yeah. I would be really tempted to fix that now.
>
> Now, it has been this way for ages, and with my RMT hat on (aka I need
> to show the example), I'd suggest to wait for when the v18 branch
> opens as there is no urgency. I'm OK to apply it myself at the end,
> the patch is a good idea.
On this specific patch, maybe reword "parameter too large" to "parameter
number too large".
Also, I was bemused by the use of atol(), which is notoriously
unportable (sizeof(long)). So I poked around and found more places that
might need fixing. I'm attaching a patch here with annotations too look
at later.
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-WIP-atol-investigation.patch | text/plain | 4.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2024-05-16 07:02:36 | Re: SQL:2011 application time |
| Previous Message | Kashif Zeeshan | 2024-05-16 06:21:18 | Re: Pre-Commitfest Party on StHighload conf |