Re: Change log level for notifying hot standby is waiting non-overflowed snapshot

From: torikoshia <torikoshia(at)oss(dot)nttdata(dot)com>
To: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Change log level for notifying hot standby is waiting non-overflowed snapshot
Date: 2025-03-24 14:18:07
Message-ID: 21bd91ba632219282627c02927988682@oss.nttdata.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2025-03-24 00:08, Fujii Masao wrote:

>>
>> Do you also think the errhint message is unnecessary?
>> I agree with your idea to add a description of the overflowed
>> subtransaction in the manual, but I'm not sure all users will be able
>> to find it.
>> Some people may not understand what needs to be done to make the
>> snapshot ready for hot standby.
>> I think adding an errhint may help those users.
>
> I see your concern that users might overlook the documentation and
> struggle to find a solution. However, I still believe it's better to
> include this information in the documentation rather than logging it
> as a hint. Since the scenario where the hint would be useful is
> relatively rare, logging it every time might be more confusing than
> helpful.

Thanks for your opinion and it sounds reasonable.

Attached an updated patch.

--
Regards,

--
Atsushi Torikoshi
Seconded from NTT DATA GROUP CORPORATION to SRA OSS K.K.

Attachment Content-Type Size
v2-0001-Change-log-message-when-hot-standby-is-not-access.patch text/x-diff 4.1 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2025-03-24 14:22:17 Re: Support NOT VALID / VALIDATE constraint options for named NOT NULL constraints
Previous Message Andrei Lepikhov 2025-03-24 14:11:55 Re: Add Postgres module info