| From: | Sutou Kouhei <kou(at)clear-code(dot)com> |
|---|---|
| To: | sawada(dot)mshk(at)gmail(dot)com |
| Cc: | michael(at)paquier(dot)xyz, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Make COPY format extendable: Extract COPY TO format implementations |
| Date: | 2024-11-05 08:43:28 |
| Message-ID: | 20241105.174328.1705956947135248653.kou@clear-code.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
In <CAD21AoAdj-EJOH1o2fTLke-uskSvuenT--fKW9nkLzYcLwU_eg(at)mail(dot)gmail(dot)com>
"Re: Make COPY format extendable: Extract COPY TO format implementations" on Mon, 4 Nov 2024 22:19:07 -0800,
Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> I've further investigated the performance regression, and found out it
> might be relevant that the compiler doesn't inline the
> CopyFromTextLikeOneRow() function. It might be worth testing with
> pg_attribute_always_inline instead of 'inline' as below:
Wow! Good catch!
I've rebased on the current master and updated the v20 and
v21 patch sets with "pg_attribute_always_inline" not
"inline".
The v22 patch set is for the v20 patch set.
(TO/FROM changes are in one commit.)
The v23 patch set is for the v21 patch set.
(TO/FROM changes are separated for easy to merge only FROM
or TO part.)
I'll run benchmark on my environment again.
Thanks,
--
kou
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2024-11-05 09:08:17 | Re: Doc: typo in config.sgml |
| Previous Message | Thomas Munro | 2024-11-05 07:59:33 | Re: Segfault in jit tuple deforming on arm64 due to LLVM issue |