| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: improve performance of pg_dump --binary-upgrade |
| Date: | 2024-04-18 21:19:24 |
| Message-ID: | 20240418211924.GA3828609@nathanxps13 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Apr 18, 2024 at 10:33:08PM +0200, Daniel Gustafsson wrote:
> From a read-through they look good, a very nice performance improvement in an
> important path. I think it would be nice with some comments on the
> BinaryUpgradeClassOids struct (since the code using it is thousands of lines
> away), and a comment on the if (oids == NULL) block explaining the caching.
Added. Thanks for reviewing! Unfortunately, this one will have to sit for
a couple months...
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Remove-is_index-parameter-from-binary_upgrade_set.patch | text/x-diff | 3.7 KB |
| v3-0002-Improve-performance-of-pg_dump-binary-upgrade.patch | text/x-diff | 8.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2024-04-18 21:22:10 | Re: Cannot find a working 64-bit integer type on Illumos |
| Previous Message | Nathan Bossart | 2024-04-18 21:01:58 | Re: Popcount optimization using AVX512 |