| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: improve performance of pg_dump --binary-upgrade |
| Date: | 2024-04-18 20:28:13 |
| Message-ID: | 20240418202813.GA3669511@nathanxps13 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Apr 18, 2024 at 10:23:01AM -0500, Nathan Bossart wrote:
> On Thu, Apr 18, 2024 at 09:24:53AM +0200, Daniel Gustafsson wrote:
>> That does indeed seem like a saner approach. Since we look up the relkind we
>> can also remove the is_index parameter to binary_upgrade_set_pg_class_oids
>> since we already know that without the caller telling us?
>
> Yeah. It looks like that's been possible since commit 9a974cb, so I can
> write a prerequisite patch for this.
Here's a new patch set with this change.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Remove-is_index-parameter-from-binary_upgrade_set.patch | text/x-diff | 3.7 KB |
| v2-0002-Improve-performance-of-pg_dump-binary-upgrade.patch | text/x-diff | 7.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2024-04-18 20:29:27 | Re: Cannot find a working 64-bit integer type on Illumos |
| Previous Message | Daniel Gustafsson | 2024-04-18 20:26:33 | Re: Cutting support for OpenSSL 1.0.1 and 1.0.2 in 17~? |