From: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
---|---|
To: | heikki(dot)linnakangas(at)iki(dot)fi |
Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | Re: pgsql: Enhance libpq encryption negotiation tests with new GUC |
Date: | 2024-04-08 06:40:10 |
Message-ID: | 20240408.154010.1170771365226258348.horikyota.ntt@gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
At Sun, 07 Apr 2024 23:50:08 +0000, Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi> wrote in
> Enhance libpq encryption negotiation tests with new GUC
This commit adds the following messages:
> gettext_noop("Log details of pre-authentication connection handshake."),
Similar to a nearby commit, other messages with a similar context use
the phrase "Logs <something>". Wouldn't it be better to align this
message with existing ones?
diff --git a/src/backend/utils/misc/guc_tables.c b/src/backend/utils/misc/guc_tables.c
index 83e3a59d7e..4584829992 100644
--- a/src/backend/utils/misc/guc_tables.c
+++ b/src/backend/utils/misc/guc_tables.c
@@ -1227,7 +1227,7 @@ struct config_bool ConfigureNamesBool[] =
},
{
{"trace_connection_negotiation", PGC_POSTMASTER, DEVELOPER_OPTIONS,
- gettext_noop("Log details of pre-authentication connection handshake."),
+ gettext_noop("Logs details of pre-authentication connection handshake."),
NULL,
GUC_NOT_IN_SAMPLE
},
regards
--
Kyotaro Horiguchi
NTT Open Source Software Center
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Langote | 2024-04-08 07:15:33 | pgsql: Fix restriction on specifying KEEP QUOTES in JSON_QUERY() |
Previous Message | Kyotaro Horiguchi | 2024-04-08 06:24:02 | Re: pgsql: Transform OR clauses to ANY expression |