From: | Sutou Kouhei <kou(at)clear-code(dot)com> |
---|---|
To: | andres(at)anarazel(dot)de |
Cc: | peter(at)eisentraut(dot)org, tristan(at)neon(dot)tech, michael(at)paquier(dot)xyz, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: meson: Specify -Wformat as a common warning flag for extensions |
Date: | 2024-04-08 01:01:17 |
Message-ID: | 20240408.100117.1165016889947781960.kou@clear-code.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi Andres,
Thanks for reviewing this!
In <20240407232635(dot)fq4kc5556lahaoej(at)awork3(dot)anarazel(dot)de>
"Re: meson: Specify -Wformat as a common warning flag for extensions" on Sun, 7 Apr 2024 16:26:35 -0700,
Andres Freund <andres(at)anarazel(dot)de> wrote:
> This seems like a fair amount of extra configure tests. Particularly because
> /W* isn't ever interesting for Makefile.global - they're msvc flags - because
> you can't use that with msvc.
>
> I'm also doubtful that it's worth supporting warning_level=3/everything, you
> end up with a completely flood of warnings that way.
OK. I've removed "/W*" flags and warning_level==3/everything
cases.
How about the attached v5 patch?
Thanks,
--
kou
Attachment | Content-Type | Size |
---|---|---|
v5-0001-meson-Restore-implicit-warning-debug-optimize-fla.patch | text/x-patch | 3.3 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2024-04-08 01:03:53 | Coverity complains about simplehash.h's SH_STAT() |
Previous Message | Tom Lane | 2024-04-08 00:58:36 | Re: WIP Incremental JSON Parser |