| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | John Naylor <johncnaylorls(at)gmail(dot)com>, Ants Aasma <ants(at)cybertec(dot)at>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: add AVX2 support to simd.h |
| Date: | 2024-03-27 18:57:16 |
| Message-ID: | 20240327185716.GA4188857@nathanxps13 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Mar 26, 2024 at 09:48:57PM -0400, Tom Lane wrote:
> Nathan Bossart <nathandbossart(at)gmail(dot)com> writes:
>> I just did the minimal fix for now, i.e., I moved the new label into the
>> SIMD section of the function. I think it would be better stylistically to
>> move the one-by-one logic to an inline helper function, but I didn't do
>> that just in case it might negatively impact performance. I'll look into
>> this and will follow up with another patch if it looks good.
>
> Sounds like a plan.
Here's what I had in mind. My usual benchmark seems to indicate that this
shouldn't impact performance.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-improve-style-of-pg_lfind32.patch | text/x-diff | 2.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Maciek Sakrejda | 2024-03-27 19:10:02 | Re: Possibility to disable `ALTER SYSTEM` |
| Previous Message | Alvaro Herrera | 2024-03-27 18:46:19 | Re: [EXTERNAL] Re: Add non-blocking version of PQcancel |