Re: pgsql: Add TAP test to automate the equivalent of check_guc

Christoph Berg <myon(at)debian(dot)org> writes:
> this test is failing at Debian package compile time:
> Could not open /usr/share/postgresql/15/postgresql.conf.sample: No such file or directory at t/003_check_guc.pl line 47.

> So it's trying to read from /usr/share/postgresql which doesn't exist
> yet at build time.

> The relevant part of the test is this:

> # Find the location of postgresql.conf.sample, based on the information
> # provided by pg_config.
> my $sample_file =
> $node->config_data('--sharedir') . '/postgresql.conf.sample';

This seems like a pretty bad idea even if it weren't failing outright.
We should be examining the version of the file that's in the source
tree; the one in the installation tree might have version-skew
problems, if you've not yet done "make install".

regards, tom lane