Re: tablecmds.c/MergeAttributes() cleanup

On 2023-Aug-29, Nathan Bossart wrote:

> On Tue, Aug 29, 2023 at 08:44:02PM +0200, Alvaro Herrera wrote:

> > Makes sense. However, maybe we should replace those ugly defines and
> > their hardcoded values in DefineSequence with a proper array with their
> > names and datatypes.
>
> That might be an improvement, but IIUC you'd still need to enumerate all of
> the columns or data types to make sure you use the right get-Datum
> function. It doesn't help that last_value uses Int64GetDatumFast and
> log_cnt uses Int64GetDatum. I could be missing something, though.

Well, for sure I meant to enumerate everything that was needed,
including the initializer for the value. Like in the attached patch.

However, now that I've actually written it, I don't find it so pretty
anymore, but maybe that's just because I don't know how to write the
array assignment as a single statement instead of a separate statement
for each column.

But this should silence the warnings, anyway.

--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/