From: | "Karl O(dot) Pinc" <kop(at)karlpinc(dot)com> |
---|---|
To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Doc: Rework contrib appendix -- informative titles, tweaked sentences |
Date: | 2023-01-19 17:03:53 |
Message-ID: | 20230119110353.78ba5217@slate.karlpinc.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-www |
On Thu, 19 Jan 2023 13:35:17 +0100
Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
> On 2023-Jan-18, Karl O. Pinc wrote:
>
> > Oops. Already sent a revised patch that includes starting each
> > module on a new page, for PDF output. I'll wait to rip that
> > out after review and start a new thread if necessary.
(I have not removed the PDF page breaks from the latest patch.)
> Here's my review in the form of a delta patch.
Love it.
> I didn't find that a thing called "ISN" actually exists. Is there a
> reference to that?
Maybe. I came across it somewhere and it seemed useful. It's
an initialism for International Standard Number.
https://en.wikipedia.org/wiki/International_Standard_Number
It's the same ISN as in the file name, "isn.sgml".
I've frobbed the ISN related text in my response patch.
(And added a line break to btree-gin.)
Attached are 2 patches, a regular and a delta from your v4 review:
contrib_v5-delta.patch.txt
contrib_v5.patch.txt
Regards,
Karl <kop(at)karlpinc(dot)com>
Free Software: "You don't pay back, you pay forward."
-- Robert A. Heinlein
Attachment | Content-Type | Size |
---|---|---|
contrib_v5-delta.patch.txt | text/plain | 1008 bytes |
contrib_v5.patch.txt | text/plain | 30.1 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Greg Stark | 2023-01-19 17:07:41 | Re: Experiments with Postgres and SSL |
Previous Message | gkokolatos | 2023-01-19 16:42:06 | Re: Add LZ4 compression in pg_dump |
From | Date | Subject | |
---|---|---|---|
Next Message | Karl O. Pinc | 2023-01-19 18:02:05 | Re: Doc: Rework contrib appendix -- informative titles, tweaked sentences |
Previous Message | Alvaro Herrera | 2023-01-19 12:35:17 | Re: Doc: Rework contrib appendix -- informative titles, tweaked sentences |