Re: pgsql: Prefetch data referenced by the WAL, take II.

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Thomas Munro <tmunro(at)postgresql(dot)org>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Prefetch data referenced by the WAL, take II.
Date: 2022-09-04 07:54:50
Message-ID: 20220904075450.6g4nm4hralyw3tab@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 2022-Apr-07, Thomas Munro wrote:

> Prefetch data referenced by the WAL, take II.

I propose a small wording change in guc.c,

diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c
index 9fbbfb1be5..9803741708 100644
--- a/src/backend/utils/misc/guc.c
+++ b/src/backend/utils/misc/guc.c
@@ -2840,7 +2840,7 @@ static struct config_int ConfigureNamesInt[] =
{
{"wal_decode_buffer_size", PGC_POSTMASTER, WAL_RECOVERY,
gettext_noop("Maximum buffer size for reading ahead in the WAL during recovery."),
- gettext_noop("This controls the maximum distance we can read ahead in the WAL to prefetch referenced blocks."),
+ gettext_noop("This controls the maximum distance we can read ahead in the WAL to prefetch data blocks referenced therein."),
GUC_UNIT_BYTE
},
&wal_decode_buffer_size,

"referenced blocks" seems otherwise a bit unclear to me. Other wording
suggestions welcome. I first thought of "...to prefetch referenced data
blocks", which is probably OK too.

--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
"Siempre hay que alimentar a los dioses, aunque la tierra esté seca" (Orual)

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2022-09-04 08:18:21 Re: pgsql: Add ALTER SUBSCRIPTION ... SKIP.
Previous Message Alvaro Herrera 2022-09-04 07:38:33 Re: pgsql: pg_collation_actual_version() -> pg_collation_current_version().

Browse pgsql-hackers by date

  From Date Subject
Next Message Ibrar Ahmed 2022-09-04 07:56:58 Re: pgbench: using prepared BEGIN statement in a pipeline could cause an error
Previous Message Alvaro Herrera 2022-09-04 07:38:33 Re: pgsql: pg_collation_actual_version() -> pg_collation_current_version().