From: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
---|---|
To: | michael(at)paquier(dot)xyz |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Inconvenience of pg_read_binary_file() |
Date: | 2022-06-30 01:59:52 |
Message-ID: | 20220630.105952.545831058411592439.horikyota.ntt@gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
At Tue, 07 Jun 2022 17:29:31 +0900 (JST), Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> wrote in
> pg_read_file(text, bool) makes sense to me, but it doesn't seem like
> to be able to share C function with other variations.
> pg_read_binary_file() need to accept some out-of-range value for
> offset or length to signal that offset and length are not specified.
In this version all the polypmorphic variations share the same body
function. I tempted to add tail-reading feature but it would be
another feature.
> (function comments needs to be edited and docs are needed)
- Simplified the implementation (by complexifying argument handling..).
- REVOKEd EXECUTE from the new functions.
- Edited the signature of the two functions.
> - pg_read_file ( filename text [, offset bigint, length bigint [, missing_ok boolean ]] ) → text
> + pg_read_file ( filename text [, offset bigint, length bigint ] [, missing_ok boolean ] ) → text
And registered this to the next CF.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
Attachment | Content-Type | Size |
---|---|---|
v3-0001-Add-an-argument-variation-to-pg_read_file.patch | text/x-patch | 7.3 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Justin Pryzby | 2022-06-30 02:24:37 | Re: Add test of pg_prewarm extenion |
Previous Message | kuroda.hayato@fujitsu.com | 2022-06-30 01:50:15 | RE: Multi-Master Logical Replication |