| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: USE_BARRIER_SMGRRELEASE on Linux? |
| Date: | 2022-02-18 18:01:44 |
| Message-ID: | 20220218180144.GA3446294@nathanxps13 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Feb 16, 2022 at 01:00:53PM -0800, Nathan Bossart wrote:
> On Wed, Feb 16, 2022 at 11:27:31AM -0800, Andres Freund wrote:
>> That doesn't strike me as great architecturally. E.g. in theory the same
>> problem could exist in single user mode. I think it doesn't today, because
>> RegisterSyncRequest() will effectively "absorb" it immediately, but that kind
>> of feels like an implementation detail?
>
> Yeah, maybe that is a reason to add an absorb somewhere within
> CreateCheckPoint() instead, like v1 [0] does. Then the extra absorb would
> be sufficient for single-user mode if the requests were not absorbed
> immediately.
Here is a new patch. This is essentially the same as v1, but I've spruced
up the comments and the commit message.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Fix-race-condition-between-DROP-TABLESPACE-and-ch.patch | text/x-diff | 4.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2022-02-18 18:27:16 | Re: Condition pushdown: why (=) is pushed down into join, but BETWEEN or >= is not? |
| Previous Message | Renan Soares Lopes | 2022-02-18 17:47:14 | [PATCH] Add support to table_to_xmlschema regex when timestamp has time zone |