Re: ERROR: "ft1" is of the wrong type.

From: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
To: peter(dot)eisentraut(at)enterprisedb(dot)com
Cc: michael(at)paquier(dot)xyz, ahsan(dot)hadi(at)gmail(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: ERROR: "ft1" is of the wrong type.
Date: 2021-07-09 01:44:13
Message-ID: 20210709.104413.1800713570585460422.horikyota.ntt@gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

At Thu, 8 Jul 2021 10:02:53 +0200, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> wrote in
> My patch is now committed. The issue that started this thread now behaves
> like this:
>
> ALTER TABLE ft1 ATTACH PARTITION ...;
> ERROR: ALTER action ATTACH PARTITION cannot be performed on relation "ft1"
> DETAIL: This operation is not supported for foreign tables.
>
> So, for PG15, this is taken care of.

Cool.

> Backpatches under the old style for missing combinations would still be in
> scope, but there my comment on the proposed patches is that I would rather not
> remove apparently unused combinations from back branches.

Sounds reasonable. So the attached are that for PG11-PG14. 11 and 12
shares the same patch.

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

Attachment Content-Type Size
v2-0001-Add-missing-targets-in-ATWrongRelkindError_PG14.patch text/x-patch 2.0 KB
v2-0001-Add-missing-targets-in-ATWrongRelkindError_PG13.patch text/x-patch 1.8 KB
v2-0001-Add-missing-targets-in-ATWrongRelkindError_PG12-11.patch text/x-patch 1.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2021-07-09 01:50:57 Re: bugfix: when the blocksize is 32k, the function page_header of pageinspect returns negative numbers.
Previous Message Michael Paquier 2021-07-09 01:29:07 Re: Incorrect usage of strtol, atoi for non-numeric junk inputs