| From: | Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp> |
|---|---|
| To: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Gregory Smith <gregsmithpgsql(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, david(dot)christensen(at)crunchydata(dot)com |
| Subject: | Re: pgbench logging broken by time logic changes |
| Date: | 2021-06-17 08:55:42 |
| Message-ID: | 20210617175542.ad6b9b82926d8469e8520324@sraoss.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, 17 Jun 2021 10:18:03 +0200 (CEST)
Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> wrote:
>
> >> Wouldn't it be better to put all those fixes into the same bag?
> >
> > Attached.
>
> Even better if the patch is not empty.
I found you forgot to fix printProgressReport().
Also, according to the document, interval_start in Aggregated Logging
seems to be printed in seconds instead of ms.
<para>
Here is some example output:
<screen>
1345828501 5601 1542744 483552416 61 2573
1345828503 7884 1979812 565806736 60 1479
1345828505 7208 1979422 567277552 59 1391
1345828507 7685 1980268 569784714 60 1398
1345828509 7073 1979779 573489941 236 1411
</screen></para>
If we obey the document and keep the back-compatibility, we should fix
logAgg().
The attached patch includes these fixes.
Regards,
Yugo Nagata
--
Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp>
| Attachment | Content-Type | Size |
|---|---|---|
| pgbench-log-fix-7.patch | text/x-diff | 5.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Boris Kolpackov | 2021-06-17 09:04:06 | Add version macro to libpq-fe.h |
| Previous Message | Amit Kapila | 2021-06-17 08:54:35 | Re: [bug?] Missed parallel safety checks, and wrong parallel safety |