From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | Neil Chen <carpenter(dot)nail(dot)cz(at)gmail(dot)com> |
Cc: | Stephen Frost <sfrost(at)snowman(dot)net>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Tom Kincaid <tomjohnkincaid(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com> |
Subject: | Re: Key management with tests |
Date: | 2021-04-06 18:42:17 |
Message-ID: | 20210406184217.GE12179@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Apr 6, 2021 at 04:56:36PM +0800, Neil Chen wrote:
> Hi Bruce,
>
> I went through these patches and executed the test script you added for the KMS
> section, which looks all good.
Thank you for checking it. The src/test/crypto/t/003_clusterkey.pl test
is one of the craziest tests I have ever written, so I am glad it worked
for you.
> This is a point that looks like a bug - in patch 10, you changed the location
> and use of *RelFileNodeSkippingWAL()*, but the modified code logic seems
> different from the original when encryption is not enabled. After applying this
> patch, it still will execute the set LSN code flow when RelFileNodeSkippingWAL
> returns true, and encryption not enabled.
You are very correct. That 'return' inside the 'if' statement gave me
trouble, and MarkBufferDirtyHint() was the hardest function I had to
deal with. Attached is an updated version of patches with a rebase; the
GitHub links listed on the wiki are updated too.
Thanks for your help.
--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EDB https://enterprisedb.com
If only the physical world exists, free will is an illusion.
Attachment | Content-Type | Size |
---|---|---|
cfe-01-doc_over_master.diff | text/x-diff | 10.1 KB |
cfe-02-internaldoc_over_cfe-01-doc.diff | text/x-diff | 11.4 KB |
cfe-03-scripts_over_cfe-02-internaldoc.diff | text/x-diff | 13.4 KB |
cfe-04-common_over_cfe-03-scripts.diff | text/x-diff | 32.8 KB |
cfe-05-crypto_over_cfe-04-common.diff | text/x-diff | 23.1 KB |
cfe-06-backend_over_cfe-05-crypto.diff | text/x-diff | 21.2 KB |
cfe-07-bin_over_cfe-06-backend.diff | text/x-diff | 33.4 KB |
cfe-08-pg_alterckey_over_cfe-07-bin.diff | text/x-diff | 30.5 KB |
cfe-09-test_over_cfe-08-pg_alterckey.diff | text/x-diff | 113.4 KB |
cfe-10-hint_over_cfe-09-test.diff | text/x-diff | 14.3 KB |
cfe-11-gist_over_cfe-10-hint.diff | text/x-diff | 6.6 KB |
cfe-12-rel_over_cfe-11-gist.diff | text/x-diff | 31.8 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Melanie Plageman | 2021-04-06 18:59:23 | Re: Parallel Full Hash Join |
Previous Message | Mahendra Singh Thalor | 2021-04-06 18:37:08 | Re: Can we remove extra memset in BloomInitPage, GinInitPage and SpGistInitPage when we have it in PageInit? |