From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
---|---|
To: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
Cc: | Amit Langote <amitlangote09(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: ALTER TABLE .. DETACH PARTITION CONCURRENTLY |
Date: | 2021-03-17 17:48:43 |
Message-ID: | 20210317174843.GA29968@alvherre.pgsql |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2021-Mar-15, Alvaro Herrera wrote:
> Here's a fixup patch to do it that way. I tried running the commands
> you showed and one of them immediately dies with the new error message;
> I can't cause the bogus constraint to show up anymore.
Actually, that was a silly fix that didn't actually work correctly, as I
discovered immediately after sending it. The right fix is to forbid all
commands other than DETACH PARTITION FINALIZE in a partition that's in
the process of being detached.
In the attached v8, I did that; I also added a ton more tests that
hopefully show how the feature should work in concurrent cases,
including one case in which the transaction doing the detach is
cancelled. I also renamed "inhdetached" to "inhdetachpending", per
previous discussion, including changing how to looks in psql.
I am not aware of any other loose end in this patch; I consider this
version final. Barring further problem reports, I'll get this pushed
tomorrow morning.
psql completion is missing. If somebody would like to contribute that,
I'm grateful.
--
Álvaro Herrera 39°49'30"S 73°17'W
"If you have nothing to say, maybe you need just the right tool to help you
not say it." (New York Times, about Microsoft PowerPoint)
Attachment | Content-Type | Size |
---|---|---|
v8-0001-Let-ALTER-TABLE-exec-routines-deal-with-the-relat.patch | text/x-diff | 3.6 KB |
v8-0002-ALTER-TABLE-.-DETACH-CONCURRENTLY.patch | text/x-diff | 109.2 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2021-03-17 18:15:31 | Re: Getting better results from valgrind leak tracking |
Previous Message | Tomas Vondra | 2021-03-17 17:33:01 | Re: Index Skip Scan (new UniqueKeys) |