From: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
---|---|
To: | ibrar(dot)ahmad(at)gmail(dot)com |
Cc: | gkokolatos(at)protonmail(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org, masao(dot)fujii(at)oss(dot)nttdata(dot)com |
Subject: | Re: shared-memory based stats collector |
Date: | 2021-03-09 07:53:11 |
Message-ID: | 20210309.165311.1236411325770761646.horikyota.ntt@gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
At Mon, 8 Mar 2021 21:55:31 +0500, Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com> wrote in
> The code does not compile and has compilation warnings and errors.
>
>
> ------
> pgstat.c:446:25: note: ‘cached_slrustats’ declared here
> static PgStat_SLRUStats cached_slrustats;
> ^~~~~~~~~~~~~~~~
> guc.c:4372:4: error: use of undeclared identifier 'pgstat_temp_directory';
> did you mean 'pgstat_stat_directory'?
> &pgstat_temp_directory,
> ^~~~~~~~~~~~~~~~~~~~~
> pgstat_stat_directory
> ../../../../src/include/pgstat.h:922:14: note: 'pgstat_stat_directory'
> declared here
> extern char *pgstat_stat_directory;
> ^
> guc.c:4373:3: error: use of undeclared identifier 'PG_STAT_TMP_DIR'
> PG_STAT_TMP_DIR,
> ^
> guc.c:4374:25: error: use of undeclared identifier
> 'assign_pgstat_temp_directory'
> check_canonical_path, assign_pgstat_temp_directory, NULL
Thanks! That's a stupid bug sneaked in by past rebasing and somehow
had lurked outside my sight.
The attached is a new version of this patchset.
- Amendmentof Fujii-san's comments (in 0003-Make-archiver..)
- Fix removal of pgstat_temp_directory.
- Fixed a bug in EXEC_BACKEND build.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
Attachment | Content-Type | Size |
---|---|---|
v49-0001-sequential-scan-for-dshash.patch | text/x-patch | 9.2 KB |
v49-0002-Add-conditional-lock-feature-to-dshash.patch | text/x-patch | 6.2 KB |
v49-0003-Make-archiver-process-an-auxiliary-process.patch | text/x-patch | 19.3 KB |
v49-0004-Shared-memory-based-stats-collector.patch | text/x-patch | 308.3 KB |
v49-0005-Doc-part-of-shared-memory-based-stats-collector.patch | text/x-patch | 19.7 KB |
v49-0006-Remove-the-GUC-stats_temp_directory.patch | text/x-patch | 13.6 KB |
v49-0007-Exclude-pg_stat-directory-from-base-backup.patch | text/x-patch | 1.2 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Joel Jacobson | 2021-03-09 08:01:16 | Re: [PATCH] regexp_positions ( string text, pattern text, flags text ) → setof int4range[] |
Previous Message | Kyotaro Horiguchi | 2021-03-09 07:51:10 | Re: shared-memory based stats collector |