From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, David Rowley <drowley(at)postgresql(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: pg_dump, ATTACH, and independently restorable child partitions |
Date: | 2020-12-02 22:50:13 |
Message-ID: | 20201202225013.GJ24052@telsasoft.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Nov 25, 2020 at 06:35:19PM -0500, Tom Lane wrote:
> Justin Pryzby <pryzby(at)telsasoft(dot)com> writes:
> > 1. Maybe pg_restore ExecuteSqlCommandBuf() should (always?) call
> > ExecuteSimpleCommands() instead of ExecuteSqlCommand(). It doesn't seem to
> > break anything (although that surprised me).
>
> That certainly does break everything, which I imagine is the reason
> why the cfbot shows that this patch is failing the pg_upgrade tests.
Thanks for looking, I have tried this.
> What we'd need to do if we want this to work with direct-to-DB restore
> is to split off the ATTACH PARTITION command as a separate TOC entry.
> That doesn't seem amazingly difficult, and it would even offer the
> possibility that you could extract the partition standalone without
> having to ignore errors. (You'd use -l/-L to select the CREATE TABLE,
> the data, etc, but not the ATTACH object.)
--
Justin
Attachment | Content-Type | Size |
---|---|---|
v4-0001-pg_dump-output-separate-object-for-ALTER-TABLE.AT.patch | text/x-diff | 9.6 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Stephen Frost | 2020-12-02 22:57:01 | Re: Add docs stub for recovery.conf |
Previous Message | Andrew Dunstan | 2020-12-02 22:36:06 | Re: Commitfest 2020-11 is closed |