From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
---|---|
To: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Cc: | Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>, Surafel Temesgen <surafel3000(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Julien Rouhaud <rjuju123(at)gmail(dot)com> |
Subject: | Re: bulk typos |
Date: | 2020-10-31 02:08:01 |
Message-ID: | 20201031020801.GD3080@telsasoft.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sun, Oct 25, 2020 at 02:48:49PM -0500, Justin Pryzby wrote:
> On Sat, Mar 31, 2018 at 05:56:40AM -0500, Justin Pryzby wrote:
> > I needed another distraction so bulk-checked for typos, limited to comments in
> > *.[ch].
> >
> > I'm not passionate about this, but it serves the purpose of reducing the
> > overhead of fixing them individually.
>
> I happened across this old patch, so ran this again to find new typos.
>
> There's a few that I don't know how best to fix.
I've added a few more, but still not sure about these two.
> Pavel, I can't understand this one.
> I guess s/producement/producing/ is too simple of a fix.
> Please check my proposed language.
> +XmlTableFetchRow(TableFuncScanState *state)
> + * XmlTable returns table - set of composite values. The error context, is
> + * used for producement more values, between two calls, there can be
> + * created and used another libxml2 error context. ...
>
> Surafel, this typo existed twice in the original commit (357889eb1).
> One instance was removed by Tom in 35cb574aa. Should we simply fix the typo,
> or borrow Julien/Tom's lanuage?
> + * Tuple at limit is needed for comparation in subsequent
> + * execution to detect ties.
Attachment | Content-Type | Size |
---|---|---|
0001-pgindent-typos.patch | text/x-diff | 1.3 KB |
v2-0001-bulk-typos.patch | text/x-diff | 12.8 KB |
v2-0002-s-rewinded-rewound.patch | text/x-diff | 1.6 KB |
v2-0003-others.patch | text/x-diff | 3.8 KB |
v2-0004-More-likely-to-be-less-likely.patch | text/x-diff | 1.1 KB |
v2-0005-comparison-but-see-also-language-changed-at-35cb5.patch | text/x-diff | 856 bytes |
v2-0006-producement-fcec6caafa2346b6c9d3ad5065e417733bd63.patch | text/x-diff | 1.4 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Thomas Munro | 2020-10-31 02:27:45 | Re: Collation versioning |
Previous Message | Tomas Vondra | 2020-10-31 01:46:17 | Re: Stats collector's idx_blks_hit value is highly misleading in practice |