| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Matthieu Garrigues <matthieu(dot)garrigues(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Dave Cramer <davecramer(at)postgres(dot)rocks>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: PATCH: Batch/pipelining support for libpq |
| Date: | 2020-10-26 19:09:36 |
| Message-ID: | 20201026190936.GA18705@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I started reading this patch. As a starting point I decided to post an
updated copy (v22), wherein I reverted the overwriting of
src/include/port/linux.h with the win32.h contents (?) and the inclusion
of <windows.h> in libpq-fe.h. If those are needed, some different
solution will have to be found.
Trivial other changes (pgindent etc); nothing of substance. With the
PQtrace() patch I posted at [1] the added test program crashes -- I
don't know if the fault lies in this patch or the other one.
[1] https://postgr.es/m/20201026162313.GA22502@alvherre.pgsql
| Attachment | Content-Type | Size |
|---|---|---|
| v22-0001-libpq-batch.patch | text/x-diff | 86.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fabrízio de Royes Mello | 2020-10-26 19:47:30 | Re: Commitfest 2020-11 |
| Previous Message | Anastasia Lubennikova | 2020-10-26 18:09:17 | Commitfest 2020-11 |