| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: expose parallel leader in CSV and log_line_prefix |
| Date: | 2020-08-03 04:41:52 |
| Message-ID: | 20200803044152.GL3317@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jul 31, 2020 at 10:31:13PM -0500, Justin Pryzby wrote:
> Also, I was reminded by Tom's c410af098 about this comment:
>
> * Further note: At least on some platforms, passing %*s rather than
> * %s to appendStringInfo() is substantially slower, so many of the
> * cases below avoid doing that unless non-zero padding is in fact
> * specified.
>
> It seems we can remove that hack and avoid its spiriling conditionals.
> It's cleaner to make that 0001.
Not sure what 0001 is doing on this thread, so I would suggest to
create a new thread for that to attract the correct audience. It is
true that we should not need that anymore as we use our own
implementation of sprintf now.
For now, I have taken 0002 as a base, fixed a couple of things (doc
tweaks, removed unnecessary header inclusion, etc.), and committed it,
meaning that we are done here.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Justin Pryzby | 2020-08-03 04:59:48 | [PATCH v1] elog.c: Remove special case which avoided %*s format strings.. |
| Previous Message | Peter Geoghegan | 2020-08-03 04:13:06 | Re: new heapcheck contrib module |